Skip to content

story/HOP-60#48

Open
Girik1105 wants to merge 5 commits intodevelopfrom
story/HOP-60
Open

story/HOP-60#48
Girik1105 wants to merge 5 commits intodevelopfrom
story/HOP-60

Conversation

@Girik1105
Copy link
Copy Markdown
Contributor

@Girik1105 Girik1105 commented Apr 28, 2026

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

It should be possible to upload a zip file of pdfs

Description

This will likely change somewhat in the future, but the process should stay the same:
in the admin interface for pdf resources, I want to be able to upload a zip file that contains:
multiple pdfs
a file that contains some metadata about the files (this is the part that will likely change)
Hopper should upload each file to the KB server
in the future we might send the metadata along with the file as well
Hopper should use the metadata from the file to fill in metadata fields for pdf resources (right now that would be just title)
let’s make the metadata file a csv file for now with two columns: filename, title
we assume the pdfs are all next to the metadata file

HOP-60

Anything else the reviewer needs to know?

The KB MCP Is still timing out when we upload a zip, thats why I created a draft pr.

Does this Pull request depend on any other?

@diging-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@jdamerow jdamerow changed the title story/HOP-61 story/HOP-60 May 1, 2026
@Girik1105 Girik1105 closed this May 1, 2026
@Girik1105 Girik1105 reopened this May 4, 2026
@Girik1105 Girik1105 marked this pull request as ready for review May 4, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants