Skip to content

bug/HOP-57#44

Open
Girik1105 wants to merge 6 commits intodevelopfrom
bug/HOP-57
Open

bug/HOP-57#44
Girik1105 wants to merge 6 commits intodevelopfrom
bug/HOP-57

Conversation

@Girik1105
Copy link
Copy Markdown
Contributor

No description provided.

@diging-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@jdamerow
Copy link
Copy Markdown
Member

This is probably a worthwhile improvement, however, we need a way to consolidate hopper's db with the kb if files have been uploaded but not linked, so this part of the ticket is still needed:

Maybe show the pdf resource with a button that lets me select resources found in the MCP but not in Hopper?

@jdamerow
Copy link
Copy Markdown
Member

Make it so, Jenkins.

Comment thread hospexplorer/ask/tasks.py
obj.mcp_kb_document_id = result.get("doc_id")
obj.save(update_fields=["mcp_kb_document_id"])
except Exception:
logger.exception("Background KB %s upload failed for resource_id=%s", model_label, resource_id)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors need to be communicated back to the user. we probably want to attach a status to the objects that indicate success, processing, error and maybe warning, with a message that we can then show in the admin interface.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigger files still time out, so there is a use case to test this with.

@jdamerow jdamerow closed this Apr 21, 2026
@Girik1105 Girik1105 reopened this Apr 23, 2026
@jdamerow
Copy link
Copy Markdown
Member

jdamerow commented May 1, 2026

Resolve conflicts please

@jdamerow jdamerow closed this May 1, 2026
@Girik1105 Girik1105 reopened this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants