Conversation
|
@achou11 Should this be a |
I would say so yeah, for the sake of consistency |
achou11
left a comment
There was a problem hiding this comment.
Need to update the include field in tsconfig.npm.json to have "src/schema.js" so that the relevant types file is emitted.
Also (because I'm not sure): do we only want to export the types from schema or is it preferable to re-export the entire module? Doing the former would require additional changes.
|
I think re-exporting just the root of schema should be enough judging by how stuff is being imported in mobile and desktop https://github.com/search?q=repo%3Adigidem%2Fcomapeo-mobile%20%22%40comapeo%2Fschema%22&type=code https://github.com/search?q=repo%3Adigidem%2Fcomapeo-desktop%20%22%40comapeo%2Fschema%22&type=code https://github.com/search?q=repo%3Adigidem%2Fcomapeo-cloud%20%22%40comapeo%2Fschema%22&type=code |
As we discussed, this should make versioning schema along with core easier on downstream dependants. We'll need to update the schema related imports to pull from
@comapeo/core/schemaShould I add more docs somewhere before merging?