Skip to content

feat: Export comapeo-schema#1235

Merged
RangerMauve merged 4 commits intomainfrom
feat/export-schema
Mar 9, 2026
Merged

feat: Export comapeo-schema#1235
RangerMauve merged 4 commits intomainfrom
feat/export-schema

Conversation

@RangerMauve
Copy link
Contributor

As we discussed, this should make versioning schema along with core easier on downstream dependants. We'll need to update the schema related imports to pull from @comapeo/core/schema

Should I add more docs somewhere before merging?

@RangerMauve RangerMauve requested review from ErikSin and achou11 March 5, 2026 21:08
@RangerMauve RangerMauve self-assigned this Mar 5, 2026
@RangerMauve RangerMauve added the enhancement New feature or request label Mar 5, 2026
@RangerMauve RangerMauve marked this pull request as ready for review March 5, 2026 21:09
@RangerMauve
Copy link
Contributor Author

@achou11 Should this be a .js export, too, then?

@achou11
Copy link
Member

achou11 commented Mar 9, 2026

@achou11 Should this be a .js export, too, then?

I would say so yeah, for the sake of consistency

Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the include field in tsconfig.npm.json to have "src/schema.js" so that the relevant types file is emitted.

Also (because I'm not sure): do we only want to export the types from schema or is it preferable to re-export the entire module? Doing the former would require additional changes.

@RangerMauve
Copy link
Contributor Author

@RangerMauve RangerMauve requested a review from achou11 March 9, 2026 18:28
@RangerMauve RangerMauve merged commit 2dfb9c6 into main Mar 9, 2026
10 of 11 checks passed
@RangerMauve RangerMauve deleted the feat/export-schema branch March 9, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants