feat: Allow assigning roles to creator#1216
Merged
RangerMauve merged 8 commits intomainfrom Feb 10, 2026
Merged
Conversation
achou11
requested changes
Feb 2, 2026
Member
achou11
left a comment
achou11
left a comment
There was a problem hiding this comment.
Changes overall make sense to me. Noticed a minor blocker that should be addressed before merging.
Is it expected that the new test takes a while? On my machine it takes around 45 seconds to finish...CI is stalled due to issues with GitHub right now, but would be interested to know how it performs there.
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
Contributor
Author
Member
achou11
previously approved these changes
Feb 2, 2026
gmaclennan
reviewed
Feb 3, 2026
achou11
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1206
Review wanted: Basic sanity check or suggestions for more tests