chore: fix remote server test for duplicate server add issue#1201
Merged
gmaclennan merged 3 commits intomainfrom Dec 9, 2025
Merged
chore: fix remote server test for duplicate server add issue#1201gmaclennan merged 3 commits intomainfrom
gmaclennan merged 3 commits intomainfrom
Conversation
553882b to
d5552a6
Compare
RangerMauve
approved these changes
Dec 9, 2025
Contributor
RangerMauve
left a comment
There was a problem hiding this comment.
LGTM.
Do you know why this change works where the parallel case failed? If that's an issue we'll likely encounter it eventually. (race condition in calling get project while another get project is in progress?)
Member
Author
|
The issue causing the original parallel test failure is digidem/comapeo-cloud#66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1200 I skipped running the new failing test on a remote server because the test setup was failing. The underlying issue is that there is a different race condition bug in the server when two clients try to add the same project to the server at the same time, which is low-priority to fix and I'm tracking in this issue: digidem/comapeo-cloud#66
This PR updates the test to add the duplicate server to the project sequentially. The underlying issue was not adding a duplicate server at exactly the same time, but two devices adding the same server while not connected / syncing with each other, so this updated test should catch the issue.
Although this PR only updates the test, I have reverted the fix, then added the test as a separate commit, to verify that the test actually fails prior to the fix still.
I recommend reviewing with the "Hide whitespace" option in Github, to help focus on the lines that have changed.