chore: remove nbsphinx link and use the pydata theme to render our documentation #67
+39
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbillinge this is ready for review. This also addresses the error that vince ran into at the following comment: Done in collaboration with @ycexiao |
sbillinge
reviewed
Aug 4, 2025
docs/source/conf.py
Outdated
| @@ -64,7 +72,7 @@ | |||
| source_suffix = [".rst", ".md"] | |||
|
|
|||
| # The encoding of source files. | |||
| # source_encoding = 'utf-8-sig' | |||
| # source_encoding = eutf-8-sig' | |||
| @@ -134,7 +142,7 @@ | |||
| # The theme to use for HTML and HTML Help pages. See the documentation for | |||
| # a list of builtin themes. | |||
| # | |||
| html_theme = "sphinx_rtd_theme" | |||
There was a problem hiding this comment.
lets comment out sphinx_rtd_theme in case we want to go back some time
ycexiao
reviewed
Aug 4, 2025
|
@sbillinge ready for review |
|
great work getting to the bottome of this! Thanks so much. |
|
Docs are well rendered on https://pyobjcryst.readthedocs.io/en/migration/. Nice. Interesting to see how you got rid of nbsphinx_lnk. What I can see:
Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.