-
Notifications
You must be signed in to change notification settings - Fork 18
skpkg: migrate documentation, README, and public static files #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #203 +/- ##
==========================================
Coverage 97.23% 97.23%
==========================================
Files 20 20
Lines 903 903
==========================================
Hits 878 878
Misses 25 25 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know htis is a draft but I left some comments. I expect that many of the "deleted" files will reappear as you move them over. Thanks for putting the PR up early as a draft!
AUTHORS.rst
Outdated
|
||
Billinge Group and community contributors. | ||
Sangjoon Lee, Simon Billinge, Billinge Group members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay as it was.
CHANGELOG.rst
Outdated
============= | ||
|
||
.. current developments | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need all these old changelogs.
CODE_OF_CONDUCT.rst
Outdated
@@ -67,7 +67,7 @@ Enforcement | |||
|
|||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | |||
reported to the community leaders responsible for enforcement at | |||
[email protected]. All complaints will be reviewed and investigated promptly and fairly. | |||
[email protected]. All complaints will be reviewed and investigated promptly and fairly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be my columbia email if possible. If this change is coming from skpkg, could we put in an issue to change it there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change comes from the original pyproject.toml file, which listed your non-Columbia email. I can change this back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha. Yes, I would like this changed to my Columbia email in this case, though it was a good choice to have the instinct to change it the way you did....
@sbillinge when trying to migrate the doc/manual directory, I found that certain files were too large (exceeds 500KB) and pre-commit wouldn't pass. How should I go about doing it? |
@zmx27 I often see merge commits in your commit history. These should appear very rarely or never. Why are they happening? |
@sbillinge Sometimes it's because I forget to run |
so this not the correct workflow. First always sync upstream and build your new branch from the base. But if you did that, you don't synchronize your local with upstream except on rare occasions. which would be discussed in the PR convo. If things have diverged with upstream and there is a conflict, we would like to understand why before just simply merging. For the manual migration, we do want to move it over. Make a PR moving everything that is not too bg and we will merge that. Then describe in the PR which files are failing "too large" check and we can discuss. |
I think I will just redo this branch instead. I will make a new PR when I'm finished. |
No description provided.