Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add columns to track job execution time #28

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

johnjcsmith
Copy link
Collaborator

@johnjcsmith johnjcsmith commented Dec 29, 2023

Adds two new columns on job for latency metrics:

  • resulted_at the time that a job result was persisted.
  • function_execution_time the time in milliseconds of a function handler execution.

Will follow up with #29 to update ts-client to record the runtime handler latency.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 1:02am

@johnjcsmith johnjcsmith force-pushed the track-function-latency branch from acf87f9 to f9dd43d Compare December 29, 2023 22:42
@johnjcsmith johnjcsmith changed the title feat: Track function latency feat: Add columns to track job latency Dec 29, 2023
@johnjcsmith johnjcsmith requested a review from nadeesha December 29, 2023 22:47
@johnjcsmith johnjcsmith marked this pull request as ready for review December 29, 2023 22:47
@johnjcsmith johnjcsmith changed the title feat: Add columns to track job latency feat: Add columns to track job execution time Dec 30, 2023
@nadeesha nadeesha merged commit 83afd89 into main Dec 30, 2023
6 checks passed
@nadeesha nadeesha deleted the track-function-latency branch December 30, 2023 01:09
nadeesha pushed a commit that referenced this pull request Dec 30, 2023
Updates `ts-client` to record function execution time (requires changes
in #28)
nadeesha added a commit that referenced this pull request Dec 30, 2023
Renders execution time from #28 if available

<img width="1429" alt="image"
src="https://github.com/differentialhq/differential/assets/9162298/64c1217f-9c9d-4f26-9d73-8eda944466f2">

Co-authored-by: Nadeesha Cabral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants