-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add columns to track job execution time #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johnjcsmith
force-pushed
the
track-function-latency
branch
from
December 29, 2023 22:42
acf87f9
to
f9dd43d
Compare
johnjcsmith
changed the title
feat: Track function latency
feat: Add columns to track job latency
Dec 29, 2023
johnjcsmith
commented
Dec 29, 2023
johnjcsmith
commented
Dec 30, 2023
johnjcsmith
changed the title
feat: Add columns to track job latency
feat: Add columns to track job execution time
Dec 30, 2023
nadeesha
reviewed
Dec 30, 2023
nadeesha
approved these changes
Dec 30, 2023
nadeesha
pushed a commit
that referenced
this pull request
Dec 30, 2023
Updates `ts-client` to record function execution time (requires changes in #28)
nadeesha
added a commit
that referenced
this pull request
Dec 30, 2023
Renders execution time from #28 if available <img width="1429" alt="image" src="https://github.com/differentialhq/differential/assets/9162298/64c1217f-9c9d-4f26-9d73-8eda944466f2"> Co-authored-by: Nadeesha Cabral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new columns on
job
for latency metrics:resulted_at
the time that a job result was persisted.function_execution_time
the time in milliseconds of a function handler execution.Will follow up with #29 to update
ts-client
to record the runtime handler latency.