Skip to content

Simplifier: do not create extractbits with pointer type #8678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

tautschnig
Copy link
Collaborator

This is a fix-up for 525c23d: we must not remove typecasts towards pointers when the operand is extractbits as our back-ends do not support extractbits with pointer type.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (062962c) to head (a7e7d83).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8678      +/-   ##
===========================================
- Coverage    80.39%   80.39%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207383   207384       +1     
  Branches        73       73              
===========================================
- Hits        166731   166729       -2     
- Misses       40652    40655       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This is a fix-up for 525c23d: we must not remove typecasts towards
pointers (or floatbv) when the operand is extractbits as our back-ends
do not support extractbits with pointer type and casts towards floatbv
are non-trivial.
@tautschnig tautschnig force-pushed the fixup-typecast-simp branch from ed9cd59 to a7e7d83 Compare July 23, 2025 21:41
@tautschnig tautschnig merged commit 4a1a325 into diffblue:develop Jul 24, 2025
59 of 60 checks passed
@tautschnig tautschnig deleted the fixup-typecast-simp branch July 24, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants