Add last_insert_rowid method to SqliteConnection and RawConnection#4977
Open
Alexi24601 wants to merge 3 commits intodiesel-rs:mainfrom
Open
Add last_insert_rowid method to SqliteConnection and RawConnection#4977Alexi24601 wants to merge 3 commits intodiesel-rs:mainfrom
Alexi24601 wants to merge 3 commits intodiesel-rs:mainfrom
Conversation
Contributor
|
@weiznich LGTM, the only thing that could be improved at all could maybe be to replace the INSERT/DELETE raw SQL in the test submodules with actual ORM calls if I really were to be extra nitpicky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes SQLite's
sqlite3_last_insert_rowid()throughSqliteConnection, following the same pattern as the existingrows_affected_by_last_query.Returns
Option<i64>—Noneif no INSERT has been performed on the connection,Some(rowid)otherwise.Example
Notes
@LucaCappelletti94 made me aware of the need to do this, so i tried my hand at this. It is still among the very first pr i do, i am still learning Rust and how to properly use git.