Made Inner and JoinWithImplicitOnClause accessible#4943
Open
LucaCappelletti94 wants to merge 2 commits intodiesel-rs:mainfrom
Open
Made Inner and JoinWithImplicitOnClause accessible#4943LucaCappelletti94 wants to merge 2 commits intodiesel-rs:mainfrom
Inner and JoinWithImplicitOnClause accessible#4943LucaCappelletti94 wants to merge 2 commits intodiesel-rs:mainfrom
Conversation
Contributor
Author
|
With this PR, it is now possible to write, using nested tuples, variadic joins as shown here. With those, in turn, I was able to write variadic select queries of different kinds, as shown here. |
Member
|
Given #3223 I would rather not like to expose these types as this restricts any future possibility to change the type level representation of these joins later on to fix that issue at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses discussion #4942:
JoinWithImplicitOnClauseas a sealed traitjoins::Innermarker structThis is done in order to specify trait constraints necessary to use the
inner_joinmethod on a generic typeT, which requires:T: JoinWithImplicitOnClause<Rhs, Inner>.