Skip to content

Made Inner and JoinWithImplicitOnClause accessible#4943

Open
LucaCappelletti94 wants to merge 2 commits intodiesel-rs:mainfrom
LucaCappelletti94:reexport-inner-join
Open

Made Inner and JoinWithImplicitOnClause accessible#4943
LucaCappelletti94 wants to merge 2 commits intodiesel-rs:mainfrom
LucaCappelletti94:reexport-inner-join

Conversation

@LucaCappelletti94
Copy link
Contributor

This PR addresses discussion #4942:

This is done in order to specify trait constraints necessary to use the inner_join method on a generic type T, which requires: T: JoinWithImplicitOnClause<Rhs, Inner>.

@LucaCappelletti94 LucaCappelletti94 marked this pull request as ready for review January 20, 2026 08:55
@LucaCappelletti94
Copy link
Contributor Author

With this PR, it is now possible to write, using nested tuples, variadic joins as shown here.

With those, in turn, I was able to write variadic select queries of different kinds, as shown here.

@weiznich
Copy link
Member

Given #3223 I would rather not like to expose these types as this restricts any future possibility to change the type level representation of these joins later on to fix that issue at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants