Add PostgreSQL jsonpath type and jsonb_path_* functions#4918
Open
majiayu000 wants to merge 2 commits intodiesel-rs:mainfrom
Open
Add PostgreSQL jsonpath type and jsonb_path_* functions#4918majiayu000 wants to merge 2 commits intodiesel-rs:mainfrom
majiayu000 wants to merge 2 commits intodiesel-rs:mainfrom
Conversation
This commit implements the following PostgreSQL JSON path functions: - jsonb_path_exists (with variants for vars, silent) - jsonb_path_match (with variants for vars, silent) - jsonb_path_query_array (with variants for vars, silent) - jsonb_path_query_first (with variants for vars, silent) Also adds timezone-aware variants (_tz) for all the above functions. Closes: diesel-rs#4216 (partial) Signed-off-by: majiayu000 <1835304752@qq.com>
Add all jsonb_path_* function types to the list of shadowed types in make_proxy_mod macro to prevent duplicate re-export errors when both helper_types_proxy and expression_dsl_proxy glob-import these types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
weiznich
reviewed
Jan 16, 2026
Member
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR and sorry for taking that long to have at least an initial look at the change.
Overall this addition looks good to me. I still want to verify the null value handling on the newly added functions and see if there is a reasonable set of tests there. Hopefully I get that done next week.
Otherwise the tests still seem to fail with a failure related to this change. Would you mind having a look at that? Do you need help there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements PostgreSQL JSON path query functions as part of #4216:
JsonpathSQL type: Added support for PostgreSQL'sjsonpathtype with OID 4072jsonb_path_exists(with_with_varsand_with_vars_and_silentvariants)jsonb_path_match(with_with_varsand_with_vars_and_silentvariants)jsonb_path_query_array(with_with_varsand_with_vars_and_silentvariants)jsonb_path_query_first(with_with_varsand_with_vars_and_silentvariants)_tzvariants for the above functionsEach function includes:
#[auto_type]test coverageTest plan
cargo check -p diesel --features "postgres serde_json"cargo fmt --all -- --check#[auto_type]tests for all new functionsRelated issues
Partially addresses #4216