Add missing type export conditions and index.d.cts #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the library has types, it's missing the proper conditional
types
exports inpackage.json
that causes any project usingnode16
orbundler
module resolution in Typescript to fail to build:You can also see the types failing to resolve here:
This PR adds in the missing
types
condition toexports
(and a requiredindex.d.cts
that's just a copy ofindex.d.ts
) so that Typescript is happy and can resolve types and compile:Note that you'll still need
skipLibCheck: true
intsconfig.json
regardless of your module settings until #247 is fixed though.