fix: handle value types and missing data to style by data item in event layers [DHIS2-19215] #3488
+564
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [DHIS2-17711] (#3481) name of styleDataItem is not saved with map, get the name with loadDisplayElements just as other data elements marked to be displayed. Handle scenario where an attribute is used for styling by fetching program TEA metadata. Rename "Style by data element" to "Style by data item" to clarify the possibilities.
…8] (#3480) In thematicLayer, onPeriodChange, if a popup is opened, update the popup.feature.properties state to get and display the updated value.
…7' into feat/DHIS2-19047
|
🚀 Deployed on https://pr-3488.maps.netlify.dhis2.org |
…2-19047] (#3473) Support proper coordinateName in legend and popup. Add tests for the different locations: TE / Enr / TEA / Evt / DE. Update documentation.
BRaimbault
changed the title
…7' into fix/DHIS2-19215
BRaimbault
force-pushed
the
feat/release-DHIS2-17711-and-DHIS2-19008-and-DHIS2-19047
branch
2 times, most recently
from
08b7486 to
4f11d3f
Compare
Base automatically changed from
feat/release-DHIS2-17711-and-DHIS2-19008-and-DHIS2-19047
to
master
March 17, 2025 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-19215
Description
Pending
TODO
Screenshots
Pending