docs: Add example to relationship model [DHIS2-19169] #1529
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
reviewed
Mar 24, 2025
|
|
||
| ## Example { #relationship_model_example } | ||
|
|
||
| <img src="resources/images/relationship_model/relationships.png" width="50%"/> |
There was a problem hiding this comment.
Did you choose the img tag to specify the width? This seems to be the first usage. Other images are added like
| <img src="resources/images/relationship_model/relationships.png" width="50%"/> | ||
|
|
||
| * Bidirectional relationship *relA* connects *teA* to *teB* and connects *teB* to *teA*. | ||
| * Unidirectional relationship *relB* connects *teA* to *teC* but DO NOT connect *teC* to *teA*. |
There was a problem hiding this comment.
Suggested change
| * Unidirectional relationship *relB* connects *teA* to *teC* but DO NOT connect *teC* to *teA*. | |
| * Unidirectional relationship *relB* connects *teA* to *teC* but DOES NOT connect *teC* to *teA*. |
| @@ -71,3 +71,15 @@ One important thing to note about bidirectional relationships, are that the | |||
| "from" and "to" sides are still significant in the database, meaning each entity | |||
| must match the constraint for that side. However, from a user perspective, which | |||
| side each entity is stored as is insignificant. | |||
|
|
|||
| ## Example { #relationship_model_example } | |||
There was a problem hiding this comment.
Not sure how exactly but it would be great if that image would integrate with all of the text above. I think that would make the text easier to understand. Also an image where the relationships are nodes with from/to edges would help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an example to better explain the relationship model and how we name things