fix: embedded dashboards configuration error ui #3247
Conversation
|
🚀 Deployed on https://pr-3247.dashboard.netlify.dhis2.org |
|
I think we should consider a different solution. With this implementation, you are basically stuck and can't use the dashboard app at all, right? Instead of SystemSettingProvider returning a Notice component, it should just return the value of "hasConfigurationError" and then let the ViewDashboard decide how to handle it. It should still be possible to view other dashboards, create regular dashboards, etc. Just that the option to create embedded dashboards is removed and existing embedded dashboards could show an error, with a link to go to the dashboard start page. |
src/pages/view/SupersetDashboard.js
Outdated
| constructor() { | ||
| super( | ||
| i18n.t( | ||
| 'Could not load dashboard content because Superset Gateway is unavailable' |
There was a problem hiding this comment.
I think there was a suggestion for a different error message in the feature channel.
…teway is not available
…or further clarification
HendrikThePendric
force-pushed
the
fix/error-ui-for-superset-gateway-config-error
branch
from
d4fc875 to
8f4ed52
Compare
|
Implements DHIS2-19275
Key features
Description
Apart from the points mentioned in the key features, this PR also addresses a bug 3c5fe12 and removes a redundant selector function 924d4c8
Test instructions
To test the "happy path" i.e. where everything is working as it should be, just use the Netlify link and connect to
https://debug.dhis2.org/dev. Here you should be seeing the Superset dashboards load correctly. So this would be regression testing.To test the changes implemented here, use the same netlify link and connect to another v42 test instance, for example
https://test.e2e.dhis2.org/analytics-dev. Now check the "Enable embedded dashboards" checkbox in system settings. To see the implemented error view, just create an embedded dashboard and try to view it.Screenshot