fix: hide the global header in print mode [DHIS2-19241] #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3245.dashboard.netlify.dhis2.org |
jenniferarnesen
requested review from
BRaimbault
and removed request for
HendrikThePendric
jenniferarnesen
added
the
e2e record
dashboards-app
|
||||||||||||||||||||||||||||
| Project |
dashboards-app
|
| Branch Review |
fix/global-header-print-mode
|
| Run status |
|
| Run duration | 01m 48s |
| Commit |
|
| Committer | Jen Jones Arnesen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
7
|
| View all changes introduced in this branch ↗︎ | |
|
BRaimbault
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Does not look like: "the print one-item-per-page displays for {string} dashboard" is used anywhere else, is it? You may consider removing it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-19241
Description
If the global shell header exists in the top document, then show/hide that header when in print mode. Otherwise, show/hide the current header.
Test instance for 42 with custom build deployed: https://dev.im.dhis2.org/jen-analytics-42-0
TODO
Screenshots
Before:
After: