chore: Remove leaflet CDN dependencies #4001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Deployed on https://deploy-preview-4001.capture.netlify.dhis2.org |
Comment on lines
-53
to
-54
| <link rel='stylesheet' href='https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.3.3/leaflet.css'> | ||
| <link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/leaflet.draw/0.4.2/leaflet.draw.css"/> |
There was a problem hiding this comment.
The map is, as far as I know, the only component that uses leaflet. With these changes, the component appears to be broken. Before removing these CDN dependencies, we need to make sure everything still works, both when capturing coordinates and when capturing a polygon area.
Thanks!
There was a problem hiding this comment.
This was a bit of a speculative PR to see if it works, but the better solution would just be to package the dependency along with the app if it is not already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should already be packaged as part of the app build, so no reason to include them separately via a CDN.