add zip64 support #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feymartynov
commented
Dec 3, 2018
| ctx[:csize] :: size(32)-little, | ||
| ctx[:usize] :: size(32)-little | ||
| ctx[:csize] :: size(64)-little, | ||
| ctx[:usize] :: size(64)-little |
There was a problem hiding this comment.
https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT
4.3.9.2 When compressing files, compressed and uncompressed sizes SHOULD be stored in ZIP64 format (as 8 byte values) when a file's size exceeds 0xFFFFFFFF. However ZIP64 format MAY be used regardless of the size of a file. When extracting, if the zip64 extended information extra field is present for the file the compressed and uncompressed sizes will be 8 byte values.
When streaming we don't know upfront whether there will be any big files. Maybe the first file is < 4 Gb but the second can be > 4 Gb. However we have to choose if we're going to use 64-bit extensions or not when streaming the first file. So this code assumes to use ZIP64 in any case.
feymartynov
commented
Dec 3, 2018
| @@ -3,9 +3,7 @@ defmodule Zipflow.Spec.CDHTest do | |||
|
|
|||
| alias Zipflow.Spec.CDH | |||
|
|
|||
| test "encode returns ()" do | |||
| ans = CDH.encode(fn x -> assert is_binary(x); nil end, []) | |||
| assert () == ans | |||
There was a problem hiding this comment.
This causes a warning in modern Elixir versions.
|
@dgvncsz0f could you please review this? |
|
Too bad this never got a response :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support of files > 4 Gb and archives > 4 Gb in total.