Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168 wip pmd 7.x #184

Merged
merged 37 commits into from
Oct 31, 2024
Merged

#168 wip pmd 7.x #184

merged 37 commits into from
Oct 31, 2024

Conversation

dgroup
Copy link
Owner

@dgroup dgroup commented Oct 14, 2024

dykov and others added 27 commits September 23, 2024 21:11
* AvoidProhibitedMethodsUsage - Fix deprecated warnings

* MissingMandatoryAnnotation - Fix deprecated warnings

* ObfuscationRequired - Fix deprecated warnings

* PotentiallyThreadLocalPollutionByMdc - Fix deprecated warnings

* UseExistingConstant - Fix deprecated warnings

* WrongRestMethodSignature - Fix deprecated warnings

* Checkstyle fixes

* Optimize imports

* Ignore rule tests

* Upgrade PMD dependency version to 7.4.0

* Fix AvoidProhibitedMethodsUsage rule

* Fix AvoidProhibitedClasses rule - from XPath to Java

* Fix ObfuscationRequired rule

* Fix AvoidMdcOutsideTryStatement rule - from XPath to Java

* Fix PotentiallyThreadLocalPollutionByMdc rule

* Fix AvoidUsingObjectMapperAsALocalVariable rule - from XPath to Java

* Update Copyright

* Update RestEndpointsWithoutExposedMetrics rule

* Fix UseConstantAsMetricName rule - from XPath to Java

* Reformat code

---------

Co-authored-by: Yurii Dubinka <[email protected]>
fix custom PMD rules (Java and XPath)
@dgroup dgroup added this to the 0.3.0 milestone Oct 14, 2024
@dgroup dgroup added the enhancement New feature or request label Oct 14, 2024
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 92.62673% with 16 lines in your changes missing coverage. Please review.

Project coverage is 94.66%. Comparing base (4ebe092) to head (9941205).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ub/dgroup/arch4u/pmd/AvoidTypeAsLocalVariable.java 91.30% 0 Missing and 4 partials ⚠️
.../github/dgroup/arch4u/pmd/ObfuscationRequired.java 84.61% 1 Missing and 3 partials ⚠️
...dgroup/arch4u/pmd/AvoidProhibitedMethodsUsage.java 84.21% 1 Missing and 2 partials ⚠️
...thub/dgroup/arch4u/pmd/AvoidProhibitedClasses.java 90.90% 1 Missing and 1 partial ⚠️
...dgroup/arch4u/pmd/AvoidMdcOutsideTryStatement.java 96.66% 0 Missing and 1 partial ⚠️
...ch4u/pmd/PotentiallyThreadLocalPollutionByMdc.java 97.91% 0 Missing and 1 partial ⚠️
...hub/dgroup/arch4u/pmd/UseConstantAsMetricName.java 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master     #184      +/-   ##
=============================================
- Coverage     100.00%   94.66%   -5.34%     
- Complexity        80      108      +28     
=============================================
  Files              6       10       +4     
  Lines            196      300     +104     
  Branches          13       22       +9     
=============================================
+ Hits             196      284      +88     
- Misses             0        3       +3     
- Partials           0       13      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@dgroup dgroup merged commit 6a3acb7 into master Oct 31, 2024
5 of 8 checks passed
@dgroup dgroup deleted the 168-wip-pmd-7.x branch October 31, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants