Skip nan for setting level. #65
Conversation
Signed-off-by: Dusan Cervenka <cervenka.dusan@gmail.com>
|
related to #64 |
Signed-off-by: Dusan Cervenka <cervenka.dusan@gmail.com>
|
Well ok we can ignore them. But we need set some value here otherwise your next lines will not work. Anyway this last commit not work for me. It looks like i am not able to get actuall value at all |
Hadatko
force-pushed
the
feature/skip_nan
branch
from
47a0a64 to
2c90a70
Compare
|
I returned to one commit earlier |
|
I wouldn't say it is specific to my dali converter as the MASK definition usage is placed in general code. Of course it maybe be used so far for my case only. |
| @@ -90,6 +90,15 @@ def level(self): | |||
| @level.setter | |||
| def level(self, value): | |||
| """Commit level to ballast.""" | |||
|
|
|||
| if not isinstance(value, (int, float)): | |||
| if hasattr(self, '__level'): | |||
There was a problem hiding this comment.
lets keep this simple, not a number ? we return without setting any value
There was a problem hiding this comment.
We need set value, otherwise you program will crash later
There was a problem hiding this comment.
can you provide a traceback of later ?
There was a problem hiding this comment.
You are accessing the value (maybe HA is asking state) and as it is not set the attribute doesn't exists. So first time there need be some value set. But we don't want overwritte existing values if they were set already.
No description provided.