During log rotation, close file before renaming it #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow FileAppender to work with any object that implements WriteString
Introducing concept of turbo filters a la logback
This reverts commit a651a06.
Add support for custom StringWriter interface to handle writing lines to log files.
Windows doesn't like it when multiple processes open the same file. This adds defer calls to close the RollingFileAppender. Also, createLogDir calls os.MkdirAll because os.Mkdir fails on Windows if the directory being created already exists.
Make tests work on Windows
Wrap logged error in ErrorWithCode
unintentionally interpolating messages that contained prior formatted
messages that contained structs. (Example: &{1})
added 10 commits
February 3, 2016 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.