You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've looked and I think maybe we can just plug this functionality into MetricsRunner that already exists. It is already doing similar stuff like record memory statistics etc. WDYT?
I've looked and I think maybe we can just plug this functionality into MetricsRunner that already exists. It is already doing similar stuff like record memory statistics etc. WDYT?
My personal preference is to have a separate task with a dedicated responsibility. That's also why Run trait is there. Separation brings more clarity and makes maintenance easier IMO. But if You feel strong about putting it into MetricsRunner, I can change it.
From my perspective more entities make it instead hard to maintain, MetricsRunner was added to solve exactly this purpose - run stuff periodically and record the results as metrics (and to generate the cache). Adding another thing that does the same... well, a lot of boilerplate for two lines of actual code I think. But, up to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.