Skip to content

Comments

chore: added API boundary nodes metrics#64

Merged
nikolay-komarevskiy merged 7 commits intomainfrom
komarevskiy/add-route-provider-stats-task
Mar 19, 2025
Merged

chore: added API boundary nodes metrics#64
nikolay-komarevskiy merged 7 commits intomainfrom
komarevskiy/add-route-provider-stats-task

Conversation

@nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Feb 19, 2025

No description provided.

@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/add-route-provider-stats-task branch from 1448875 to 4e0f1d1 Compare March 18, 2025 17:13
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review March 18, 2025 17:48
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner March 18, 2025 17:48
@blind-oracle
Copy link
Collaborator

I've looked and I think maybe we can just plug this functionality into MetricsRunner that already exists. It is already doing similar stuff like record memory statistics etc. WDYT?

@nikolay-komarevskiy
Copy link
Contributor Author

I've looked and I think maybe we can just plug this functionality into MetricsRunner that already exists. It is already doing similar stuff like record memory statistics etc. WDYT?

My personal preference is to have a separate task with a dedicated responsibility. That's also why Run trait is there. Separation brings more clarity and makes maintenance easier IMO. But if You feel strong about putting it into MetricsRunner, I can change it.

@blind-oracle
Copy link
Collaborator

From my perspective more entities make it instead hard to maintain, MetricsRunner was added to solve exactly this purpose - run stuff periodically and record the results as metrics (and to generate the cache). Adding another thing that does the same... well, a lot of boilerplate for two lines of actual code I think. But, up to you

@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/add-route-provider-stats-task branch 2 times, most recently from eb3dd71 to e617915 Compare March 19, 2025 08:19
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/add-route-provider-stats-task branch from e617915 to e171985 Compare March 19, 2025 08:20
@nikolay-komarevskiy nikolay-komarevskiy changed the title chore: addedApiBoundaryNodesStats task chore: added API boundary nodes metrics Mar 19, 2025
@nikolay-komarevskiy nikolay-komarevskiy merged commit 6eb4a8c into main Mar 19, 2025
5 checks passed
@nikolay-komarevskiy nikolay-komarevskiy deleted the komarevskiy/add-route-provider-stats-task branch March 19, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants