feat: use directive transition wrappers #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Feb 4, 2025
dskloetd
approved these changes
Feb 4, 2025
peterpeterparker
added a commit
that referenced
this pull request
Feb 12, 2025
# Motivation Revert #574 because thanks to a different way of mocking the transitions for test purposes (without vite), those workaround are not needed anymore. # Resources - Mock tested in dfinity/nns-dapp#6404 - New solution to mock the animation for test purposes with Svelte v5 providing by Testing Library in testing-library/svelte-testing-library#284 (comment) # Changes - Revert #574 and use Svelte transitions --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements the transition directives wrappers provided in #573 for the transition that lead the CI to fail in the NNS dapp Svelte v5 branch.
Changes
svelte/transition, use the wrappers that skips the transitions for testing purposesTests
I asserted this changes has no impact on the test suite of NNS dapp by integrating a manual package and running the CI successfully in dfinity/nns-dapp#6336.
We will have to mock the
ResizeObserverthough but, that's something we need for Svelte v5 testing anyway dfinity/nns-dapp#6337