Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(charts/dex): Use tpl for dynamic image values and add digest #154

Merged
merged 1 commit into from
Mar 21, 2025
Merged

feat(charts/dex): Use tpl for dynamic image values and add digest #154

merged 1 commit into from
Mar 21, 2025

Conversation

kozmagabor
Copy link
Contributor

Overview

What this PR does / why we need it

Special notes for your reviewer

  • Replaced static values with tpl for image repository, tag, and digest to allow the parent chart’s values to be passed dynamically to subchart.
  • Allow image pull using digest

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

sagikazarmark
sagikazarmark approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagikazarmark sagikazarmark merged commit 65db60c into dexidp:master Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozmagabor @sagikazarmark