fix: Role isnt respecting namespaceOverride #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Petermann <[email protected]>
peschmae
force-pushed
the
fix/missed-namepsace
branch
from
5eefff3 to
e076777
Compare
Signed-off-by: Mathias Petermann <[email protected]>
peschmae
force-pushed
the
fix/missed-namepsace
branch
from
5722141 to
ebfead7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #144 I've added the namespace to all resourced, and implement a
namespaceOverride. During refactoring I've missed the Role and it's now always created in the.Release.Namespace.What this PR does / why we need it
Fixes #151
Additionally the
NOTES.txtnow also uses thedex.namespacehelper, to ensure it shows the proper namespace in the message after installing/upgrading the chartChecklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs