Fix Makefile to Support Spaces in Paths

[EthanDieterich]

Overview

In this branch, I fixed issues my team and I encountered with the Makefile, where it would not function correctly when spaces were present in the path. The issue was traced back to how PATH and SHELL were being set, leading to failures when running make in directories with spaces in their names.

What this PR does / why we need it

• This PR ensures that paths are properly quoted in the Makefile to prevent issues caused by spaces in directory names.
• Updates how SHELL passes the PATH variable to ensure compatibility with /bin/sh while keeping the correct environment settings.
• This fix is necessary for users working in directories with spaces (e.g., /home/user/My Project/), where make previously failed due to improper path handling.

Special notes for your reviewer

[jsquyres]

Can this PR be reviewed? We have found that we need this for environments that have a PATH with a space.

Thanks!

[sagikazarmark]

I wonder if this change is the reason why tests are failing

[jsquyres]

I wonder if this change is the reason why tests are failing

Interesting:

/bin/sh: 1: protoc: Permission denied

Does this mean that make verify in the github action was previously finding a different protoc (that properly has the x bit set)?

I'm guessing that we also need:

diff --git a/Makefile b/Makefile
index 3cc72405..f189183b 100644
--- a/Makefile
+++ b/Makefile
@@ -87,6 +87,7 @@ ifeq ($(shell uname | tr A-Z a-z), linux)
        curl -L https://github.com/protocolbuffers/protobuf/releases/download/v>
 endif
        unzip bin/protoc.zip -d bin/protoc
+       chmod +x bin/protoc
        rm bin/protoc.zip
 
 bin/protoc-gen-go:

For the second CI failure:

#89 0.177 /bin/sh: uname: not found
#89 0.181 /bin/sh: uname: not found

I'm not sure if that's the actual underlying error, but I do see that in the Github Action log. I'm assuming it's from the various calls to $(shell uname) in the Makefile.

But offhand, I can't think of why adding the quotes to the PATH would make uname suddenly be unable to be found...?

Oh, actually, I see this in the log output, too:

#89 9.400 env: can't execute 'sh': No such file or directory

Odd.

[jsquyres]

I'm guessing that we also need:

I added a commit to this PR that added the chmod +x .... Could you approve the github actions again to see if that problem at least got fixed?

I haven't had time to dig into the 2nd failure yet, but I offhand wonder if that failed because protoc previously didn't run...?

[jsquyres]

Oops -- had the wrong chmod path in there. Fixed.