-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark to retrieve a random number from a specific range #15
Open
yogodoshi
wants to merge
1
commit into
devonestes:master
Choose a base branch
from
yogodoshi:random-benchmark
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
defmodule Random.Slow do | ||
def get_random_number(max) do | ||
Enum.random(1..max) | ||
end | ||
end | ||
|
||
defmodule Random.Fast do | ||
def get_random_number(max) do | ||
:rand.uniform(max) | ||
end | ||
end | ||
|
||
defmodule Random.Benchmark do | ||
def benchmark do | ||
Benchee.run(%{ | ||
":rand.uniform/1 (Fast)" => fn max -> bench(Random.Fast, max) end, | ||
"Enum.random/1 (Slow)" => fn max -> bench(Random.Slow, max) end | ||
}, | ||
time: 10, | ||
inputs: %{ | ||
"Minimal" => 10, | ||
"Small" => 1_000, | ||
"Medium" => 10_000, | ||
"Bigger" => 100_000 | ||
}, | ||
print: [fast_warning: false]) | ||
end | ||
|
||
def bench(module, max) do | ||
module.get_random_number(max) | ||
end | ||
end | ||
|
||
Random.Benchmark.benchmark() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other ways of generating a random number, like just
random:uniform()
without the limit? If we're looking at just a random number generator, there are a lot of ways to go about that that don't specify the range the number must be in. For example, there's also Erlang'srand
module, which uses a different algorithm thanrandom
but isn't truly random enough for stuff like cryptography, but might be random enough for most other uses.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I needed was to generate a random number among a range. I should've explicitly explained that in the description.
What do you want to do? I can expand this, change the description to try explain that it is generating a number between a range/limit, or just close the PR if you think it is an example that it is too broad. No hard feelings :)