Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIN!! 🗽🗽🗽🗽 #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thaiversion
Copy link

mVATOR is coming to train 🚉💪

team member

Repo
คุณซูลูทำไมเรายังไม่วาร์ป

The Dashboard
touch me plz

🕯 May the force be with YOU! 🕯

Implement Done
Implement Done
Implement Done
@annibuliful
Copy link
Collaborator

เป็น PR สุดท้ายที่สวยงามมากครับ ไม่ต้องแก้อะไรเลย น้ำตาจิไหล

import datetime #datetime
import xml.etree.ElementTree as ET #xml reader
from time import perf_counter #stopwatch
from dateutil.relativedelta import relativedelta #timedelta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a non standard library

Copy link
Author

@thaiversion thaiversion Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this mistake, maybe it came from installing some data sci lib for another project.

Screen Shot 2565-10-13 at 00 13 35

when we use this command and get no error so we accidentally decided to use it , sorry for the MISUNDERSTANDING.

ps. After I search for a while. The PYTHON standard date/datetime lib cannot calculate date difference with YEARS (unable to process 4year 1day rule) then it is impossible to do so

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me the link

Copy link
Author

@thaiversion thaiversion Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me the link

@annibuliful follow python's official documentation, the built-in lib datetime is not provided YEARS parameter with timedelta function
https://docs.python.org/3/library/datetime.html#datetime.timedelta

and One question please about scoring criteria
In date precision..
The participants should be concern about add extra 1day for every 4years pass or not ? for exactly date!
Cuz if some participant use "year" to minus with year value directly that might be some deviation on "day"/"month" value

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@thaiversion thaiversion Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/devmountaintechfest/hackathon-season2/pull/22/files#diff-d92aae6fcf09b8ae18a99689ed3006d0aca5a0e5216dc958dd0bd20ff33262c5R25

I checked from another team it seems work with standard lib

WOW that is great solution to use binary for calculate datetime! but there are 2 small bugs >>

  1. +2 years on current_datetime.year + 2 , if current year is 2023 that will make loop range to 2024 and get wrong +1 leap day cuz year2024 is Leap Year ( suggest value is current_datetime.year + 1 )
  2. current date and hired date are not focus on february month , if start day counting after the end of february month that might not necessary to add leap day

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes it should be current_datetime.year + 1 instead of current_datetime.year + 2 it was my mistake during the coding period.
  2. You stated that it might not be necessary to add leap day which means you know that this can be solved by the policy.

temp_passport_list = []
temp_fullname_list = []
temp_time_current = datetime.datetime.now()
temp_time_3yearsago = temp_time_current - relativedelta(years=3)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@annibuliful
Copy link
Collaborator

@thaiversion รบกวนขอ email หน่อยครับ

@thaiversion
Copy link
Author

thaiversion commented Oct 20, 2022

@thaiversion รบกวนขอ email หน่อยครับ

@annibuliful ขออภัยที่ตอบช้าครับ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants