Feature/init visualizer #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
รบกวนใส่ชื่อทีมและกด repo link ด้วยครับ |
|
อันนี้ Repo Link https://github.com/puthita-sam/hackathon-season2/tree/feature/init-visualizer @annibuliful |
|
|
annibuliful
requested changes
Oct 10, 2022
| from datetime import datetime | ||
|
|
||
| import os | ||
| import xmltodict |
There was a problem hiding this comment.
This is non standard library to that's not allowed to use
Comment on lines
+80
to
+103
| def clean_data(data_dict): | ||
| temp_dict = {} | ||
| pristine_records = [] | ||
|
|
||
| for index in range(len(data_dict['records']['record'])): | ||
| record = data_dict['records']['record'][index] | ||
| emp_id = record['EMPID'] | ||
| passport_no = record['PASSPORT'] | ||
| if emp_id in temp_dict and passport_no in temp_dict[emp_id]: | ||
| print('found duplicate on employee id: {} and passport no: {} > ignore'.format(emp_id, passport_no)) | ||
| elif 'GENDER' in record and record['GENDER'] not in ['0', '1']: | ||
| print('wrong gender type ({}) > ignore'.format(record['GENDER'])) | ||
| elif 'STATUS' in record and record['STATUS'] not in ['1', '2', '3']: | ||
| print('wrong status type ({}) > ignore'.format(record['STATUS'])) | ||
| elif 'STATUS' in record and record['STATUS'] != '1': | ||
| print('employee status not active ({}) > ignore'.format(record['STATUS'])) | ||
| else: | ||
| if emp_id not in temp_dict: | ||
| temp_dict[emp_id] = {} | ||
| temp_dict[emp_id][passport_no] = 'checked' | ||
| pristine_records.append(record) | ||
|
|
||
| data_dict['records']['record'] = pristine_records | ||
| return data_dict |
There was a problem hiding this comment.
Suggested change
| def clean_data(data_dict): | |
| temp_dict = {} | |
| pristine_records = [] | |
| for index in range(len(data_dict['records']['record'])): | |
| record = data_dict['records']['record'][index] | |
| emp_id = record['EMPID'] | |
| passport_no = record['PASSPORT'] | |
| if emp_id in temp_dict and passport_no in temp_dict[emp_id]: | |
| print('found duplicate on employee id: {} and passport no: {} > ignore'.format(emp_id, passport_no)) | |
| elif 'GENDER' in record and record['GENDER'] not in ['0', '1']: | |
| print('wrong gender type ({}) > ignore'.format(record['GENDER'])) | |
| elif 'STATUS' in record and record['STATUS'] not in ['1', '2', '3']: | |
| print('wrong status type ({}) > ignore'.format(record['STATUS'])) | |
| elif 'STATUS' in record and record['STATUS'] != '1': | |
| print('employee status not active ({}) > ignore'.format(record['STATUS'])) | |
| else: | |
| if emp_id not in temp_dict: | |
| temp_dict[emp_id] = {} | |
| temp_dict[emp_id][passport_no] = 'checked' | |
| pristine_records.append(record) | |
| data_dict['records']['record'] = pristine_records | |
| return data_dict | |
| def clean_data(data_dict): | |
| STATUS = ['1', '2', '3'] | |
| GENDER = ['0','1'] | |
| temp_dict = {} | |
| pristine_records = [] | |
| for index in range(len(data_dict['records']['record'])): | |
| record = data_dict['records']['record'][index] | |
| emp_id = record['EMPID'] | |
| passport_no = record['PASSPORT'] | |
| if emp_id in temp_dict and passport_no in temp_dict[emp_id]: | |
| print('found duplicate on employee id: {} and passport no: {} > ignore'.format(emp_id, passport_no)) | |
| elif 'GENDER' in record and record['GENDER'] not in GENDER: | |
| print('wrong gender type ({}) > ignore'.format(record['GENDER'])) | |
| elif 'STATUS' in record and record['STATUS'] not in STATUS: | |
| print('wrong status type ({}) > ignore'.format(record['STATUS'])) | |
| elif 'STATUS' in record and record['STATUS'] != '1': | |
| print('employee status not active ({}) > ignore'.format(record['STATUS'])) | |
| else: | |
| if emp_id not in temp_dict: | |
| temp_dict[emp_id] = {} | |
| temp_dict[emp_id][passport_no] = 'checked' | |
| pristine_records.append(record) | |
| data_dict['records']['record'] = pristine_records | |
| return data_dict |
Comment on lines
+97
to
+100
| if emp_id not in temp_dict: | ||
| temp_dict[emp_id] = {} | ||
| temp_dict[emp_id][passport_no] = 'checked' | ||
| pristine_records.append(record) |
There was a problem hiding this comment.
I guess it's used to prevent duplicated record right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Link https://github.com/puthita-sam/hackathon-season2/tree/feature/init-visualizer