feat: Add browser applet #563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fincs
reviewed
Mar 17, 2025
fincs
reviewed
Mar 17, 2025
fincs
reviewed
Mar 17, 2025
| void* buffer = malloc(url_len); | ||
| if (buffer) memcpy(buffer, url, url_len); | ||
| aptLaunchSystemApplet(APPID_WEB, buffer, url_len, 0); | ||
| if (buffer) free(buffer); |
Member
There was a problem hiding this comment.
Does the browser applet return anything useful in the buffer? Is it worth trying to send that back to the app?
Contributor
Author
There was a problem hiding this comment.
Couldn't find any evidence of that / currently nothing is known, as far as soru is aware
Sorunome
force-pushed
the
soru/browser
branch
3 times, most recently
from
af66e5f to
c0bd6a0
Compare
Contributor
Author
|
Is there anything still needed to get this PR merged? |
Contributor
|
I suspect that the browser applet returns the URL of the last redirect as the apt parameter — this needs more testing to verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to easily call the browser applet, optional at a specific address.