Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set strictnullchecks = true #1422

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

rjbrache
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@rjbrache rjbrache force-pushed the enable_strictNullChecks branch from 740b4a2 to 3d65284 Compare January 24, 2024 22:03
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 122 lines in your changes are missing coverage. Please review.

Comparison is base (ac3a957) 84.99% compared to head (b867fb1) 84.90%.

Files Patch % Lines
src/models/index.ts 0.00% 18 Missing ⚠️
src/stateMachines/activation.ts 78.94% 16 Missing ⚠️
src/ProfileManager.ts 60.60% 12 Missing and 1 partial ⚠️
src/stateMachines/ciraConfiguration.ts 89.18% 8 Missing ⚠️
src/stateMachines/unconfiguration.ts 96.25% 6 Missing ⚠️
src/certManager.ts 84.84% 5 Missing ⚠️
src/stateMachines/wiredNetworkConfiguration.ts 80.76% 5 Missing ⚠️
src/stateMachines/wifiNetworkConfiguration.ts 90.47% 4 Missing ⚠️
src/Index.ts 40.00% 3 Missing ⚠️
src/data/postgres/tables/ieee8021xProfiles.ts 80.00% 2 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1422      +/-   ##
==========================================
- Coverage   84.99%   84.90%   -0.09%     
==========================================
  Files         118      118              
  Lines        4304     4532     +228     
  Branches      789      979     +190     
==========================================
+ Hits         3658     3848     +190     
- Misses        597      631      +34     
- Partials       49       53       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsdmike rsdmike force-pushed the enable_strictNullChecks branch 2 times, most recently from 1783ee3 to 86636f4 Compare January 26, 2024 16:59
@rsdmike rsdmike changed the title Enable strict null checks refactor(format): set strictnullchecks = true Jan 26, 2024
@rsdmike rsdmike force-pushed the enable_strictNullChecks branch from 86636f4 to efd4c39 Compare January 26, 2024 17:09
@rsdmike rsdmike changed the title refactor(format): set strictnullchecks = true refactor: set strictnullchecks = true Jan 26, 2024
@rsdmike rsdmike force-pushed the enable_strictNullChecks branch from efd4c39 to b867fb1 Compare January 26, 2024 17:10
@rsdmike rsdmike marked this pull request as ready for review January 26, 2024 17:12
@rsdmike rsdmike self-requested a review January 26, 2024 17:14
@rsdmike rsdmike merged commit 7459a2b into main Jan 26, 2024
10 of 12 checks passed
@rsdmike rsdmike deleted the enable_strictNullChecks branch January 26, 2024 17:15
@RosieAMT
Copy link

RosieAMT commented Feb 8, 2024

🎉 This PR is included in version 2.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants