TMS-1108: Add new Häive color-theme #529
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @eebbi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new color theme called "Häive" to the project. This includes adding the theme to the assets test page, creating the SCSS file for the theme, adding overrides, and updating the theme color tab in the settings.
Highlights
- New Theme: A new color theme named 'Häive' has been added, providing a new visual style option.
- SCSS Implementation: The SCSS file for the 'Häive' theme defines the color palette and imports necessary theme files.
- Theme Overrides: Specific style overrides have been implemented to customize the 'Häive' theme's appearance.
- Integration: The new theme has been integrated into the assets test page and the theme color tab in settings.
Changelog
Click here to see the changelog
- CHANGELOG.MD
- Added a changelog entry for the new Häive color theme.
- assets/assets_test.html
- Added a link to the new 'theme_haive.css' stylesheet.
- Added a button to switch to the 'Häive' theme.
- assets/scripts/theme-haive.js
- Created a new JavaScript file for the 'Häive' theme, importing main.js and the theme's SCSS file.
- assets/styles/theme-haive.scss
- Created a new SCSS file for the 'Häive' theme, defining the color palette and importing necessary theme files.
- assets/styles/themes/_theme-haive-overrides.scss
- Created a new SCSS file for the 'Häive' theme overrides, customizing the appearance of various elements.
- lib/ACF/Fields/Settings/ThemeColorTab.php
- Added 'haive' to the list of available theme color options.
- webpack.config.js
- Added 'theme_haive' as a new entry point for webpack.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The primary color '#f8de79' used in the Häive theme is close to the color of Banana Mania Crayon, which was introduced by Crayola in 1997.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new Häive color theme to the project. The changes include adding the theme to the assets, webpack configuration, ACF settings, and SCSS files. Overall, the implementation seems well-structured and integrates smoothly with the existing theme system.
Summary of Findings
- TODO comment in SCSS file: The
theme-haive.scssfile contains a TODO comment regarding the color of links and icons. This should be addressed to ensure the theme is complete and visually consistent.
Merge Readiness
The pull request is almost ready for merging. However, the TODO comment in theme-haive.scss should be addressed before merging to ensure the theme is complete. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Once the TODO is resolved, the pull request should be good to go.
assets/styles/theme-haive.scss
Outdated
| $primary-dark: bulmaDarken(#f2ac58, 20); | ||
| $primary-dark-invert: $color-black; | ||
|
|
||
| $secondary: #F9ECD4; |
There was a problem hiding this comment.
| $secondary: #F9ECD4; | |
| $secondary: #f9ecd4; |
| background-color: $primary !important; | ||
| } | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
| .icon-links .icon-links { |
There was a problem hiding this comment.
Jännä toteutus kieltämättä, tää on tullut toisesta aiemman väriteeman override-tiedoston kopsauksesta. Mutta toimiihan tuo kai, ja osuu oikeaan elementtiin kun tossa seuraavalla rivillä on &__item {, eli sama kuin .icon-links .icon-links__item {
| fill: $black !important; | ||
| } | ||
| } | ||
|
|
| .related-posts { | ||
| &__item { | ||
| .button { | ||
| &, |
There was a problem hiding this comment.
Pitää olla, kun nuo tyylit on tarkotettu hoveriin, focukseen ja normaaliin ulkoasuun
Severa-ID: 2108
Severa-kuvaus: TMS-1108 Uusi värimaailmavaihtoehto kampanja- ja opetuskäytön blogiteemaan
Task: https://hiondigital.atlassian.net/browse/TMS-1108
Description
Add new Häive color theme
Types of changes