Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jan 13, 2025

Description of Changes

Summarize the changes you made as part of this pull request.

Add the necessary renovate configuration to keep the Konflux image references up to date, follows similar setup to devfile/registry.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

part of devfile/api#1667

Acceptance Criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

I ran the following to validate the renovate config file changes:

  1. export RENOVATE_CONFIG_FILE=$(pwd)/renovate.json
  2. npx --yes --package renovate -- renovate-config-validator

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Ignore warnings to migrate configuration, it appears MintMaker renovate is still using the old configuration specification.

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the chore/konflux-renovate-config branch from 98cb4d5 to 2085222 Compare January 13, 2025 16:46
@michael-valdron michael-valdron marked this pull request as ready for review January 13, 2025 22:55
@openshift-ci openshift-ci bot requested review from elsony and thepetk January 13, 2025 22:55
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 7996d6f into devfile:main Jan 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants