Skip to content

Micro-optimize action binding by preallocating arguments array #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Micro-optimize action binding by preallocating arguments array #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeec990
Optimize action binding
aduth Nov 7, 2019
5f4fbdb
Use reverse while to assign args
aduth Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"bundlesize": [
{
"path": "full/preact.js",
"maxSize": "760b"
"maxSize": "780b"
},
{
"path": "dist/unistore.js",
Expand Down
6 changes: 4 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,10 @@ export default function createStore(state) {

// Note: perf tests verifying this implementation: https://esbench.com/bench/5a295e6299634800a0349500
return function() {
let args = [state];
for (let i=0; i<arguments.length; i++) args.push(arguments[i]);
let i = arguments.length,
args = Array(arguments.length + 1);
args[0] = state;
while (i) args[i--] = arguments[i];
let ret = action.apply(this, args);
if (ret!=null) {
if (ret.then) return ret.then(apply);
Expand Down