Save facts as array #37
Conversation
berniechiu
force-pushed
the
save-facts-as-array
branch
from
afa6cda to
94287d8
Compare
|
👍 lgtm... |
| @@ -55,6 +55,10 @@ def collect_data(disease_link) | |||
| end | |||
|
|
|||
| def facts(disease_page) | |||
| disease_page.at('h3:contains("Key facts")').try(:next_element).try(:text) | |||
| parsed_lists = disease_page.at('h3:contains("Key facts")').try(:next_element) | |||
| if parsed_lists && (lists = parsed_lists.search("li")).present? | |||
There was a problem hiding this comment.
What happens when (lists = parsed_lists.search("li")).present? returns false?
I think we can return parsed_lists in that case?
There was a problem hiding this comment.
That looks like, on parsed_lists it's searches for presence of ("li"), and you are calling the result you had on parsed_lists straight to lists, And you are returning the ones that are false
parsed_lists will return true (only ones with "li"). Probably you can negate it to return false
There was a problem hiding this comment.
if false, then the result will not be set. So it becomes nil in this case. It is fine when a serialized Array column with nil is set since it will return an empty arrary.
|
@SundayAdefila did this fix #32 |
|
Not been able to check because of issue #40 😢 |
|
Update: |
Reference: #32
Features
(1) Parse facts as array object and save to DB
(2) I think rerun the migrations and parse the new data can see the result