Remove control for running Database #54
Conversation
Signed-off-by: Mahdi Fooladgar <[email protected]>
Signed-off-by: Mahdi Fooladgar <[email protected]>
controls/postgres_spec.rb
Outdated
| it { should be_running } | ||
| it { should be_enabled } | ||
| if os[:name] == 'ubuntu' | ||
| describe command('/etc/init.d/postgresql status') do |
There was a problem hiding this comment.
Does this still exist on Ubuntu 22.04? Ubuntu uses systemd..
There was a problem hiding this comment.
Yes. I've tested on both my local machine and also your docker images for molecule.
There was a problem hiding this comment.
I'm not really a fan of this solution. We depend on a file (that's not really in use anyway) and its output.. What do you think about doing it like in another baseline?
# set OS-dependent filenames and paths
case os[:family]
when 'ubuntu', 'debian'
process_name = 'postgresql'
when 'redhat', 'fedora'
process_name = 'postgres'
when 'suse'
process_name = 'postgresql'
end
Note that these are probably not the correct names..
There was a problem hiding this comment.
I also have some problems with using if here. What about we execute all describe blocks always and group them into a describe.one block (https://docs.chef.io/inspec/profiles/controls/#check-if-at-least-one-condition-passes)
There was a problem hiding this comment.
I agree with both comments and starting to fix it.
There was a problem hiding this comment.
I'm not really a fan of this solution. We depend on a file (that's not really in use anyway) and its output.. What do you think about doing it like in another baseline?
# set OS-dependent filenames and paths case os[:family] when 'ubuntu', 'debian' process_name = 'postgresql' when 'redhat', 'fedora' process_name = 'postgres' when 'suse' process_name = 'postgresql' endNote that these are probably not the correct names..
Is this example from MySQL baseline? If yes, there is no control for "mysql-conf-01" there. Can we remove this control for PostgreSQL, too? It seems the "postgres-03" also checks the state of the Postgres daemon.
There was a problem hiding this comment.
Yes, we dropped it here: dev-sec/mysql-baseline#78
So I think, we should delete the test here, too.
@schurzi, thoughts?
There was a problem hiding this comment.
sounds reasonable. Let's do this
There was a problem hiding this comment.
Removed in 17eb756.
Signed-off-by: Mahdi Fooladgar <[email protected]>
schurzi
changed the title
schurzi
changed the title
In the Ubuntu operating system, the name of the PostgreSQL service is
postgresql.