Remove jest in favor of Node's built-in test runner #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at our dependabot alerts for this repo most of them relate to dependencies that we only have because of our jest dependency. With the advent of Node's built-in test runner I took the liberty of switching us over to that, thereby removing the need for jest entirely.
I've updated our minimum required Node engine to v20 here. That's not strictly necessary, node v18 works as well (but needs a different invocation (--loader instead of --import). Since we're about to ship 3.x and Desktop is already on Node 20 I figured it's a good time to bump it though.
When we get to Node v21 we can probably skip the test.mjs script since v21 will have support for specifying glob paths directly.