Allow memoizing Results #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameroncros
force-pushed
the
feature/memoize_result
branch
from
4945ac2 to
5f430a0
Compare
Open
…f the type. (doco?) Better testing.
dermesser
reviewed
Dec 6, 2025
| @@ -1,16 +1,29 @@ | |||
| use memoize::memoize; | |||
|
|
|||
| #[memoize] | |||
Owner
There was a problem hiding this comment.
nice example, but given that this one is the trivial one, maybe keep it trivial? And instead set up a new example, e.g. result.rs?
Contributor
Author
There was a problem hiding this comment.
Done, i figured that results was also a trivial case, but thats fair enough.
Contributor
Author
|
@dermesser Do you need anything more from me on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seamlessly works with Result return types.
Only memoizes the success path, as Errors can't be cloned.
If there is more work required to get this mergable, please let me know, happy to make any required changes.