Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjusting aria attributes and testing due to 'nmtokens' #4662

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

refactor: adjusting aria attributes and testing due to 'nmtokens' #4662

wants to merge 9 commits into from

Conversation

Jeremy-Rivera
Copy link
Contributor

<< Describe the changes >>

Closes:

@Jeremy-Rivera Jeremy-Rivera requested a review from a team as a code owner January 1, 2025 19:40
stephenmathieson
stephenmathieson requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many unrelated documentation changes in this PR. I recommend splitting this into multiple PRs, enabling reviewers to focus on smaller/more focused updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeremy-Rivera @stephenmathieson