Skip to content

Fix create_proxy! macro #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Fix create_proxy! macro #12

merged 2 commits into from
Jan 2, 2020

Conversation

termoshtt
Copy link
Contributor

error: unexpected end of macro invocation
  --> /home/travis/build/denzp/rustc-llvm-proxy/target/debug/build/rustc-llvm-proxy-8a4ff3d82bd298fa/out/llvm_gen.rs:6:152
   |
6  | create_proxy!(LLVMContextSetDiagnosticHandler; (); C : LLVMContextRef , Handler : LLVMDiagnosticHandler , DiagnosticContext : * mut :: libc :: c_void ,);
   |                                                                                                                                                        ^ missing tokens in macro arguments
   | 
  ::: src/lib.rs:93:5
   |
93 |     macro_rules! create_proxy {
   |     ------------------------- when calling this macro

https://travis-ci.org/denzp/rustc-llvm-proxy/jobs/625547316

This patch fix it by removing , at the end

termoshtt added a commit to rust-accel/nvptx that referenced this pull request Dec 31, 2019
Copy link
Owner

@denzp denzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@denzp denzp merged commit 92a87f3 into denzp:master Jan 2, 2020
@denzp
Copy link
Owner

denzp commented Jan 2, 2020

I'll try to revive #7 to pass tests on linux and osx and then publish to Crates.

@denzp
Copy link
Owner

denzp commented Jan 2, 2020

Oh, scrap the last message: I've published v0.1.11 with the changes!

@denzp
Copy link
Owner

denzp commented Jan 2, 2020

Also, the v0.2.0 is out - it uses libLLVM that can be found on Linux and MacOS and it's generally more reliable approach. Unfortunately, both v0.1 and v0.2 are broken on Windows.

@termoshtt termoshtt deleted the fix_create_proxy_macro branch March 29, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants