Skip to content

Fix #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahrizvi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #1 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e525823
Fix Chalk template literal parentheses
sahrizvi Mar 11, 2020
5cc6568
Merge pull request #1 from sahrizvi/sahrizvi-patch-1
sahrizvi Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,14 +311,14 @@ if (sfc.script) {
break;
case 'beforeCreate':
if (prop.type !== 'ObjectMethod') {
console.log(chalk`{yellow Warning: in default export, } {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
console.log(chalk`{yellow Warning: in default export, {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
continue;
}
beforeCreate = unwrapFunctionBody(prop);
break;
case 'created':
if (prop.type !== 'ObjectMethod') {
console.log(chalk`{yellow Warning: in default export, } {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
console.log(chalk`{yellow Warning: in default export, {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
continue;
}
created = unwrapFunctionBody(prop);
Expand All @@ -328,7 +328,7 @@ if (sfc.script) {
case 'updated':
case 'destroyed':
if (prop.type !== 'ObjectMethod') {
console.log(chalk`{yellow Warning: in default export, } {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
console.log(chalk`{yellow Warning: in default export, {greenBright ${prop.key.name}} is not a function, ignoring it.}`);
continue;
}

Expand Down Expand Up @@ -394,7 +394,7 @@ if (sfc.script) {

for (let method of prop.value.properties) {
if (method.type !== 'ObjectMethod') {
console.log(chalk`{yellow Warning: in default export, method} {greenBright ${babelGenerator(method.key).code}} is not a function, ignoring it.}`);
console.log(chalk`{yellow Warning: in default export, method {greenBright ${babelGenerator(method.key).code}} is not a function, ignoring it.}`);
continue;
}

Expand Down Expand Up @@ -457,4 +457,4 @@ if (sfc.template) {

fs.writeFileSync(outputPath, output.join(''), 'utf8');

console.log(chalk`{greenBright Successfully converted} {yellow ${inputPath}} {greenBright to} {yellow ${outputPath}}{greenBright . Please note that some manual corrections are probably still required.}`);
console.log(chalk`{greenBright Successfully converted} {yellow ${inputPath}} {greenBright to} {yellow ${outputPath}}{greenBright . Please note that some manual corrections are probably still required.}`);