fix: remove QuotaExceededError from DOMException error names tablefix: remove QuotaExceededError from DOMException error names table#31466
Conversation
Per whatwg/webidl#1465, QuotaExceededError is no longer a specific DOMException name but will be upgraded to a DOMException subclass. This commit removes QuotaExceededError from the nameToCodeMapping so that new DOMException('msg', 'QuotaExceededError').code returns 0 instead of 22. Fixes denoland#30028
WalkthroughThe change removes "QuotaExceededError" from the DOMException name-to-code mapping, so lookups for that name yield no specific code and DOMException instances for it use code 0. The DOMException class and its public API remain unchanged. Tests were added and adjusted to assert that QuotaExceededError has code 0, name "QuotaExceededError", message "quota exceeded", and related test expectations for quota-exceeded storage cases were updated. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-11-24T16:19:37.808ZApplied to files:
🔇 Additional comments (1)
Comment |
|
Thanks, but there is already a PR open for this change: #31400. Please use search, before opening a PR. |
Per whatwg/webidl#1465, QuotaExceededError is no longer a specific DOMException name but will be upgraded to a DOMException subclass.
This PR implements the minimal fix by removing QuotaExceededError from the nameToCodeMapping so that
new DOMException('msg', 'QuotaExceededError').codereturns 0 instead of 22.Changes:
Fixes #30028Per whatwg/webidl#1465, QuotaExceededError is no longer a specific DOMException name but will be upgraded to a DOMException subclass.
This commit removes QuotaExceededError from the nameToCodeMapping so that new DOMException('msg', 'QuotaExceededError').code returns 0 instead of 22.
Fixes #30028