-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat(cli): add --allow-env-file flag #31452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| --- | ||
| description: Setup local development environment for Deno | ||
| --- | ||
|
|
||
| # Setup Local Deno Development Environment | ||
|
|
||
| This guide helps you set up your system to build and contribute to Deno. | ||
|
|
||
| ## Option 1: VS Code Dev Containers (Recommended) | ||
|
|
||
| If you use VS Code, the easiest way is to use the provided Dev Container | ||
| configuration. | ||
|
|
||
| 1. Install [Docker Desktop](https://www.docker.com/products/docker-desktop). | ||
| 2. Install the | ||
| [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) | ||
| in VS Code. | ||
| 3. Open the project folder in VS Code. | ||
| 4. Click "Reopen in Container" when prompted, or run the command | ||
| `Dev Containers: Reopen in Container`. | ||
|
|
||
| This will automatically set up all dependencies (Rust, Python, CMake, Protobuf, | ||
| etc.). | ||
|
|
||
| ## Option 2: Manual Setup | ||
|
|
||
| ### 1. Install Prerequisites | ||
|
|
||
| #### Rust | ||
|
|
||
| Deno requires a specific version of Rust. | ||
|
|
||
| ```bash | ||
| # Install rustup if you haven't | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh | ||
|
|
||
| # Install the specific version required by Deno (currently 1.90.0) | ||
| rustup install 1.90.0 | ||
| rustup default 1.90.0 | ||
| rustup component add rustfmt clippy | ||
| ``` | ||
|
|
||
| #### Python 3 | ||
|
|
||
| Ensure you have Python 3 installed and accessible as `python` or `python3`. | ||
|
|
||
| #### Protobuf Compiler | ||
|
|
||
| - **Mac:** `brew install protobuf` | ||
| - **Linux:** `apt install -y protobuf-compiler` | ||
| - **Windows:** Download binary release from GitHub. | ||
|
|
||
| #### CMake | ||
|
|
||
| - **Mac:** `brew install cmake` | ||
| - **Linux:** `apt install -y cmake` | ||
|
|
||
| #### Native Compilers | ||
|
|
||
| - **Mac:** XCode Command Line Tools (`xcode-select --install`) | ||
| - **Linux:** `apt install -y build-essential libglib2.0-dev` | ||
|
|
||
| ### 2. Build Deno | ||
|
|
||
| ```bash | ||
| # Clone with submodules if you haven't already | ||
| git submodule update --init --recursive | ||
|
|
||
| # Build | ||
| cargo build -vv | ||
| ``` | ||
|
|
||
| ### 3. Verify Setup | ||
|
|
||
| Run the tests to ensure everything is working: | ||
|
|
||
| ```bash | ||
| # Run unit tests | ||
| cargo test -vv | ||
|
|
||
| # Format code | ||
| ./tools/format.js | ||
|
|
||
| # Lint code | ||
| ./tools/lint.js | ||
| ``` | ||
|
Comment on lines
+1
to
+86
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This documentation appears unrelated to the PR objective. The PR adds a |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: denoland/deno
Length of output: 170
🌐 Web query:
Deno rust version requirement 1.90.0💡 Result:
Do you mean: (A) confirm which Rust version Deno requires to build (e.g. "Rust 1.90.0"), or (B) how to install/use Rust 1.90.0 for building Deno?
🌐 Web query:
Deno build requirements minimum Rust version💡 Result:
Short answer: Deno requires the Rust toolchain version specified in the repository's rust-toolchain.toml file — check that file in the denoland/deno repo for the exact minimum Rust version for the release you plan to build. [1][2]
How to check locally or in the repo:
Sources:
If you want, I can fetch the current rust-toolchain.toml and tell you the exact Rust version right now.
🌐 Web query:
site:github.com/denoland/deno rust-toolchain.toml💡 Result:
The file rust-toolchain.toml is present at the root of the denoland/deno repository on GitHub. [1][2]
Sources
🌐 Web query:
fetch denoland deno rust-toolchain.toml raw content current version💡 Result:
Here’s the rust-toolchain.toml content from the denoland/deno repo (current toolchain channel in the file):
[toolchain]
channel = "1.89.0"
components = ["rustfmt", "clippy"].
Sources: [1], [2]
Sources:
[1] mirror of denoland/deno rust-toolchain.toml (shows content).
[2] denoland/deno repository file listing on GitHub.
Rust version in documentation is incorrect — should be 1.89.0, not 1.90.0.
The documentation specifies Rust 1.90.0 (lines 37–38), but the project's
rust-toolchain.tomlfile specifieschannel = "1.89.0". Using the wrong version will cause build failures or unnecessary upgrades. Update the documentation to match the actual requirement:# Install the specific version required by Deno (currently 1.89.0) rustup install 1.89.0 rustup default 1.89.0 rustup component add rustfmt clippy🤖 Prompt for AI Agents