Skip to content

feat(install): don't require npm: prefix #31447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

feat(install): don't require npm: prefix #31447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cli/tools/pm/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright 2018-2025 the Deno authors. MIT license.

use std::borrow::Cow;
use std::path::Path;
use std::path::PathBuf;
use std::sync::Arc;
Expand Down Expand Up @@ -454,8 +455,14 @@ pub async fn add(
let mut package_reqs = Vec::with_capacity(add_flags.packages.len());

for entry_text in add_flags.packages.iter() {
let text =
if !entry_text.starts_with("npm:") && !entry_text.starts_with("jsr:") {
Cow::Owned(format!("npm:{}", entry_text))
} else {
Cow::Borrowed(entry_text)
};
let req = AddRmPackageReq::parse(
entry_text,
&text,
add_flags.default_registry.map(|r| r.into()),
)
.with_context(|| format!("Failed to parse package: {}", entry_text))?;
Expand Down
Loading