Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cli/tsc/dts/lib.deno.ns.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2239,6 +2239,17 @@ declare namespace Deno {
* ```
*/
close(): void;
/**
* Check if the file is closed.
*
* ```ts
* const file = await Deno.open("my_file.txt");
* console.log(file.isClosed()); // false
* file.close();
* console.log(file.isClosed()); // true
* ```
*/
isClosed(): boolean;

[Symbol.dispose](): void;
}
Expand Down
7 changes: 7 additions & 0 deletions ext/fs/30_fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ class FsFile {

#readable;
#writable;
#closed = false;

constructor(rid, symbol) {
ObjectDefineProperty(this, internalRidSymbol, {
Expand Down Expand Up @@ -650,6 +651,11 @@ class FsFile {

close() {
core.close(this.#rid);
this.#closed = true;
}

isClosed() {
return this.#closed;
}

get readable() {
Expand Down Expand Up @@ -719,6 +725,7 @@ class FsFile {

[SymbolDispose]() {
core.tryClose(this.#rid);
this.#closed = true;
}
}

Expand Down
43 changes: 43 additions & 0 deletions tests/unit/files_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,49 @@ Deno.test(
},
);

Deno.test(
{ permissions: { read: true } },
async function fsFileIsClosed() {
const file = await Deno.open("tests/testdata/assets/hello.txt");
assertEquals(file.isClosed(), false);
file.close();
assertEquals(file.isClosed(), true);
},
);

Deno.test(
{ permissions: { read: true } },
function fsFileIsClosedSync() {
const file = Deno.openSync("tests/testdata/assets/hello.txt");
assertEquals(file.isClosed(), false);
file.close();
assertEquals(file.isClosed(), true);
},
);

Deno.test(
{ permissions: { read: true } },
async function fsFileIsClosedWithUsing() {
let file2: Deno.FsFile;
{
using file = await Deno.open("tests/testdata/assets/hello.txt");
file2 = file;
assertEquals(file.isClosed(), false);
}
assertEquals(file2.isClosed(), true);
},
);

Deno.test(
{ permissions: { read: true } },
async function fsFileIsClosedAfterManualCloseInUsing() {
using file = await Deno.open("tests/testdata/assets/hello.txt");
assertEquals(file.isClosed(), false);
file.close();
assertEquals(file.isClosed(), true);
},
);

Deno.test(
{ permissions: { read: true, write: true } },
function fsFileDatasyncSyncSuccess() {
Expand Down
Loading