feat: Propagate rejections up to the functions that caused them #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jespertheend are you looking forward to finishing this? |
Contributor
Author
|
Hey sorry for the delay, I've been using this in production for more than a year now so I think it's probably safe to use this. I have resolved the merge conflicts, although I can't easily try the merged version in production at the moment. |
lucsoft
approved these changes
Feb 12, 2025
Collaborator
lucsoft
left a comment
lucsoft
left a comment
There was a problem hiding this comment.
@jespertheend thats awesome to hear! merging this right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
Unfortunately there are also some errors that might occur before the header has been parsed, making it impossible to know which specific message should be rejected.
I've simply made it so it rejects all pending messages in that case.
I'll try this out in production for a while to see how things go.