-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Schema Validator Page #2490
Draft
maxkrieger
wants to merge
45
commits into
master
Choose a base branch
from
enhance/schema-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
ed3c2a2
feat: add initial schema page defn
maxkrieger cc4ce49
feat: basic selection and validation
maxkrieger 83ce642
feat: Echo case matches
maxkrieger 41e5b1c
feat: Update matching interface
maxkrieger 4bef4b0
feat: stringify partial paths
maxkrieger 62815ee
feat: Autocomplete schema view
maxkrieger 13d854c
fix: stringification
maxkrieger 31da33c
feat: partial match color
maxkrieger fffc127
feat: add initial schema page defn
maxkrieger a42f374
feat: basic selection and validation
maxkrieger 58bc530
feat: Echo case matches
maxkrieger 98d9be1
feat: Update matching interface
maxkrieger cdcf242
feat: stringify partial paths
maxkrieger d75507d
feat: Autocomplete schema view
maxkrieger 35e733b
fix: stringification
maxkrieger 712b69e
feat: partial match color
maxkrieger f25bc76
Merge branch 'master' into enhance/schema-page
maxkrieger 378c2ce
Merge branch 'enhance/schema-page' of https://github.com/dendronhq/de…
maxkrieger 46743c3
fix: remove duplicate key
maxkrieger e79d020
Merge branch 'master' into enhance/schema-page
maxkrieger 86ca30c
Merge branch 'master' into enhance/schema-page
maxkrieger 6c9acfb
fix: update to latest file structure
maxkrieger 6e61ec6
feat: add schema validator command
maxkrieger 8a43172
Merge branch 'master' into enhance/schema-page
maxkrieger 541cc19
feat: add schema validator entry
maxkrieger 30a4386
feat: add initial schema page defn
maxkrieger 3d5400e
fix: rebase
maxkrieger 9edfc06
feat: Echo case matches
maxkrieger 7e8f58b
feat: Update matching interface
maxkrieger a7b53ef
feat: stringify partial paths
maxkrieger df41c55
feat: Autocomplete schema view
maxkrieger 4753b9b
fix: stringification
maxkrieger 961dd09
feat: partial match color
maxkrieger 5ef77e3
feat: basic selection and validation
maxkrieger a9e996c
feat: Echo case matches
maxkrieger c183549
fix: update to latest file structure
maxkrieger 6414cad
feat: add schema validator command
maxkrieger ff5e9ee
feat: add schema validator entry
maxkrieger 17c639a
Merge branch 'enhance/schema-page' of https://github.com/dendronhq/de…
maxkrieger d295106
Merge branch 'master' into enhance/schema-page
maxkrieger c12fbd9
Merge branch 'enhance/schema-page' of https://github.com/dendronhq/de…
maxkrieger 22c321c
fix: merge conflict marker, validator key
maxkrieger eb1d0f1
fix: successfully register validator command
maxkrieger 072bb7f
fix: make colors and view visible
maxkrieger 79a2866
fix: plugin package json
maxkrieger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/dendron-plugin-views/src/components/DendronSchemaPage.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { DendronProps } from "../types"; | ||
|
||
export default function DendronSchemaPage({}: DendronProps) { | ||
return <div>Schema Page</div>; | ||
} |
6 changes: 6 additions & 0 deletions
6
packages/dendron-plugin-views/src/views/DendronSchemaPageView.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import { renderOnDOM } from "../bootstrap"; | ||
import DendronSchemaPage from "../components/DendronSchemaPage"; | ||
|
||
renderOnDOM(DendronSchemaPage, {}); | ||
|
||
export default DendronSchemaPage; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you get this to render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add it to
VALID_NAMES
- will push soon!