fix: clippy warnings #3390
fix: clippy warnings #3390
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
| @@ -28,6 +28,7 @@ impl AsyncShareableBuffer { | |||
| } | |||
|
|
|||
| /// Returns a clone of the underlying buffer as a `Vec`. | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
some of these things that clippy claims were dead seemed important so I didn't actually removed them, I just added an allow.
I am happy to remove them too if you prefer
Signed-off-by: Andrew Lamb <[email protected]>
alamb
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
+ Coverage 71.88% 71.91% +0.02%
==========================================
Files 147 147
Lines 45848 45840 -8
Branches 45848 45840 -8
==========================================
+ Hits 32960 32966 +6
+ Misses 10784 10777 -7
+ Partials 2104 2097 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ship it:p |
Description
I would like to get a clean clippy run, to make it easier to find what deprecated APIs I need to update when upgrading to DataFusion 47:
I ran this command:
And basically did what clippy told me. I am happy to add a check for clippy to the CI as well, but figured that might be better as a follow on PR if you would like it.
Related Issue(s)
Documentation