shell scripts for cloud-init #3743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
Nagachandan-P
force-pushed
the
pub/k8s_telemetry
branch
from
655f09f to
8bee682
Compare
snarthan
approved these changes
Dec 2, 2025
jagadeeshnv
reviewed
Dec 2, 2025
| ansible.builtin.set_fact: | ||
| total_mem_mb: >- | ||
| {{ | ||
| mem_info.json.Members |
Collaborator
There was a problem hiding this comment.
add default in case Members not read
|
|
||
| - name: Calculate 90% of real memory | ||
| ansible.builtin.set_fact: | ||
| real_memory: "{{ ((total_memory_mb | float) * 0.90) | int }}" |
Collaborator
There was a problem hiding this comment.
Not using it anywhere remove it
|
|
||
| - name: Calculate total memory in MB (GiB → MB) | ||
| ansible.builtin.set_fact: | ||
| total_memory_mb: "{{ (mem_info.json.MemorySummary.TotalSystemMemoryGiB | default(default_real_memory)) * 1024 | int }}" |
Collaborator
There was a problem hiding this comment.
int conversion before multiplying is better
|
|
||
| - name: Calculate 90% of real memory | ||
| ansible.builtin.set_fact: | ||
| real_memory: "{{ ((total_memory_mb | float) * 0.90) | int }}" |
Collaborator
There was a problem hiding this comment.
This var not being used anywhere
Collaborator
There was a problem hiding this comment.
Add the MaxRAMPercent under cgroup default
jagadeeshnv
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated as shell-scripts in cloud-init with integrated logging